Skip to content

Improve getPixel error handling #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2019
Merged

Improve getPixel error handling #5

merged 1 commit into from
Sep 10, 2019

Conversation

jos-rosenqvist-3812
Copy link
Contributor

Adding a require to getPixel makes the exception for out-of-bounds coordinates be thrown in the calling thread, which makes the stack trace easier to understand.

Fixes #4.

@jos-rosenqvist-3812
Improve getPixel error handling
6f6e1d7 
Adding a require to getPixel makes the exception for
out-of-bounds coordinates be thrown in the calling thread,
which makes the stack trace easier to understand.
@bjornregnell
Copy link
Member

Thanks! Nice improvement!

@bjornregnell bjornregnell merged commit 51f9f25 into lunduniversity:master Sep 10, 2019
@jos-rosenqvist-3812 jos-rosenqvist-3812 deleted the getpixel-require branch September 17, 2019 12:00
bjornregnell added a commit that referenced this pull request Sep 18, 2019
@bjornregnell
add checks on window bounds for better err msg
064da8e 
fix issues #4 #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix require in get/setPixel in PixelWindow etc
2 participants
@jos-rosenqvist-3812 @bjornregnell