Skip to content

Conversation

slavvka
Copy link
Member

@slavvka slavvka commented Dec 11, 2019

Description (*)

  • Fixed plenty of PHP Notices
  • Changed files section currently shows only changed files without all existing JSON files and duplicates
  • Layout changes are now displayed in the report
  • Black/whitelist filtration is performed now before scanning files

Manual testing scenarios (*)

  1. Run semver against code with removed blocks and level = 1 (PATCH)
  2. There should be section Layout in the report with all removed blocks
  3. Changed files section should contain only really changed files without duplicates
  4. No PHP Notices should be present in the console

Notice

No tests provided since the current package doesn't allow to run any tests

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

- Multiple PHP Notices
- Changed files currently shows only changed files without all existing JSOn files and duplicates
- Layout changes are now displayed in the report
- Black/whitelist filtration is performed now before scanning files
@melnikovi melnikovi self-requested a review December 12, 2019 01:36
@slavvka slavvka requested a review from sidolov December 12, 2019 16:06
@magterskine magterskine merged commit cd0f3e4 into magento:master Dec 12, 2019
mmansoor-magento pushed a commit that referenced this pull request Feb 1, 2021
Add a new section to HTML SVC report
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants