POC: Mc 19094 refactoring svc #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 13, 2019 10:15
…its-own-repo COMOPS-129: Extract SVC code into its own repo
|
In general it looks reasonable for me. Please make sure you also check |
melnikovi
reviewed
Aug 22, 2019
| @@ -27,6 +27,7 @@ public function analyze($registryBefore, $registryAfter) | |||
| $analyzers = [ | |||
| new ClassAnalyzer(), | |||
| new InterfaceAnalyzer(), | |||
| // @todo should moved in a extra analyzer for a better extendability. | |||
There was a problem hiding this comment.
We try to avoid adding @todo annotation in the code. Let's add items like this to backlog and remove annotation in the code.
melnikovi
reviewed
Aug 22, 2019
| @@ -0,0 +1,102 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Need to make sure all files have Magento copyright. Dod you mention tests are green on this PR? If so need to double check if they run.
|
Closing in favor of #15 |
mmansoor-magento
pushed a commit
that referenced
this pull request
Oct 21, 2020
MQE-2329: Magento SVC does not work with nikic/php-parser version above 4.6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.