forked from dpkp/kafka-python
-
Notifications
You must be signed in to change notification settings - Fork 1
Zookeeper #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rukaya
wants to merge
12
commits into
gevent
Choose a base branch
from
zookeeper
base: gevent
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Correct behaviour during consumer rebalancing * Correct behaviour for minor APIs like close(), pending(), seek() etc. * Improved documentation
This can be made common for all producers later
The queues approach had a problem. Say the consumer is not used to fetch messages for a while. In this while the allocation has changed multiple times. When the next invocation of the consumer happens, the oldest message is fetched from the queue. It will take a while before the consumer catches up The approach has been simplified with a shared memory protected by a lock and notified using an event
Ensure that the standby consumer logic works Also add a __repr__ method for Zookeeper consumer
Other changes * If zookeeper consumer was run from the same process, kazoo Partitioner identifier would have been the same - resulting in errors. Fixed * Add support for chroot to a Zookeeper path * Remove dependency on simplejson * Reduce the sleep time for the partitioner (in acquired state)
Conflicts: kafka/client.py kafka/conn.py test/test_integration.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.