[SDK] support aggregation of identical instruments (#3358) #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use the existing storage for sync or async instruments of the same name. add tests * add hash and name case insensitive hash for InstrumentDescriptor. Update storage registry to use the hash and equality structs. Add tests. * don't allocate heap in the hash. fix some ci failures * fix a few more ci failures. * move the instrument descriptor ostream operator to meter.cc to not leak the ostream header and keep the meter instrument creation warning implementation in the same file * adds instrument descriptor tests * add comments * Move case-insensitive equals method and IsDuplicate method into InstrumentDescriptorUtils struct. Add log streamable wrappers for scopes and instrument descriptors. Add tests for correcitve views for name and description duplicates * fix iwyu errors * duplicate instrument log message improvements to match spec. minor test additions/cleanup * changelog entry * address review feedback. Add Ascii to the name of the instrument util case-insensitive equal function * address feedback: short circuit the instrument descriptor CaseInsensitiveAsciiEquals and IsDuplicate checks * fix comments --------- Co-authored-by: Tom Tan <lilotom@gmail.com> Co-authored-by: Marc Alff <marc.alff@oracle.com> Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the existing storage for sync or async instruments of the same name. add tests
add hash and name case insensitive hash for InstrumentDescriptor. Update storage registry to use the hash and equality structs. Add tests.
don't allocate heap in the hash. fix some ci failures
fix a few more ci failures.
move the instrument descriptor ostream operator to meter.cc to not leak the ostream header and keep the meter instrument creation warning implementation in the same file
adds instrument descriptor tests
add comments
Move case-insensitive equals method and IsDuplicate method into InstrumentDescriptorUtils struct. Add log streamable wrappers for scopes and instrument descriptors. Add tests for correcitve views for name and description duplicates
fix iwyu errors
duplicate instrument log message improvements to match spec. minor test additions/cleanup
changelog entry
address review feedback. Add Ascii to the name of the instrument util case-insensitive equal function
address feedback: short circuit the instrument descriptor CaseInsensitiveAsciiEquals and IsDuplicate checks
fix comments
Fixes # (issue)
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes