Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ininial sync content flush not scheduled #2525

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

rturnq
Copy link
Contributor

@rturnq rturnq commented Feb 19, 2025

Description

Synchronous content is not flushed immediately and waits until the first async flush. This change ensures an existing writer is scheduled for flush right away.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@DylanPiercey DylanPiercey merged commit 4c20455 into main Feb 19, 2025
8 checks passed
@DylanPiercey DylanPiercey deleted the fix-initial-flush branch February 19, 2025 17:57
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (69581ba) to head (5ca897b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2525   +/-   ##
=======================================
  Coverage   87.08%   87.08%           
=======================================
  Files         352      352           
  Lines       40492    40493    +1     
  Branches     2693     2693           
=======================================
+ Hits        35263    35264    +1     
  Misses       5203     5203           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants