Fixes #26 #27
Merged
Fixes #26 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ggodreau
commented
Oct 28, 2018
- /mpl-data/sample_data/axes_grid folder appears to no longer exists as of matplotlib v2.2.2
- added /assets folder in repo containing dependent numpy pickle, 'bivariate_normal.npy' file
- revised load of data in AnatomyOfMatplotlib-Part2-Plotting_Methods_Overview.ipynb to reflect this change
- tested successfully with matplotlib v2.2.2 and python v3.6.6
- /mpl-data/sample_data/axes_grid folder appears to no longer exists as of matplotlib v2.2.2 - added /assets folder in repo containing dependent numpy pickle, 'bivariate_normal.npy' file - revised load of data in AnatomyOfMatplotlib-Part2-Plotting_Methods_Overview.ipynb to reflect this change - tested successfully with matplotlib v2.2.2 and python v3.6.6
- removed redundant cell (typo on my part), line 272
|
This seems reasonable to me! Anybody have objections to including this data w/ the repo? |
|
@choldgraf I considered pulling it down from GH or a CDN but I:
So I decided it'd be easier and more reliable to include the file in the repo. T'was my raison d'etre 🗼 🍷 |
|
Not sure why sample data is not available. Maybe, because technically it's an optional package. OTOH adding a 1.8k file to this repo is not that bad either. |
|
I am a little embarrassed that I didn't think of this before. Of course, I didn't ever spend much time thinking about it because I always assumed that the sample data will always be packaged with matplotlib... This seems totally reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.