Skip to content

Fix markers table for display in JupyterLab #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2019
Merged

Fix markers table for display in JupyterLab #29

merged 2 commits into from
Apr 23, 2019

Conversation

JarnoRFB
Copy link
Contributor

Before the changes, the table was not rendered properly.

@JarnoRFB
Fix markers table for display in JupyterLab
bcf3d08 
Before the changes, the table was not rendered properly.
tacaswell
tacaswell approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, I suspect that the dialect of markdown that is acceptable drifted a bit?

@timhoffm
Copy link
Member

This is a known issue jupyterlab/jupyterlab#5007.

We "misused" empty cells to have a visual separation of the marker/description column pairs.

@timhoffm timhoffm merged commit 0ff68e0 into matplotlib:master Apr 23, 2019
@timhoffm
Copy link
Member

@JarnoRFB Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeatherGod WeatherGod WeatherGod left review comments

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JarnoRFB @timhoffm @tacaswell @WeatherGod