Skip to content

Commit d4f0d4e

Browse files
authored
Merge pull request #12093 from anntzer/wstrict-prototypes
Correct the removal of -Wstrict-prototypes from compiler flags.
2 parents 6a896b0 + f9d757c commit d4f0d4e

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

setup.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -107,15 +107,16 @@ def __init__(self, dist):
107107

108108

109109
class BuildExtraLibraries(BuildExtCommand):
110-
def run(self):
111-
# Remove the -Wstrict-prototypes option, it's not valid for C++.
110+
def build_extensions(self):
111+
# Remove the -Wstrict-prototypes option, it's not valid for C++. Fixed
112+
# in Py3.7 as bpo-5755.
112113
try:
113114
self.compiler.compiler_so.remove('-Wstrict-prototypes')
114115
except (ValueError, AttributeError):
115116
pass
116117
for package in good_packages:
117118
package.do_custom_build()
118-
return BuildExtCommand.run(self)
119+
return super().build_extensions()
119120

120121

121122
cmdclass = versioneer.get_cmdclass()

0 commit comments

Comments
 (0)