Correct the removal of -Wstrict-prototypes from compiler flags. #12093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to remove the invalid flag in run() was too early (.compiler is still None at that point so we would just always get a (silenced) AttributeError -- catching the AttributeError is necessary to make things work on Windows). Indeed, the Py3.5 build currently displays a lot of warnings about -Wstrict-prototypes. Doing the removal in build_extensions() instead works. This went unnoticed because the upstream issue in distutils (https://bugs.python.org/issue5755) was recently fixed in Py3.6.6 and 3.7.0; but this still affects Py3.5 and Py3.6.{0-5}.
tacaswell
approved these changes
Sep 12, 2018
|
But I also approved the last one so... |
|
Thanks @anntzer ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to remove the invalid flag in run() was too early (.compiler is
still None at that point so we would just always get a (silenced)
AttributeError -- catching the AttributeError is necessary to make
things work on Windows). Indeed, the Py3.5 build currently displays a
lot of warnings about -Wstrict-prototypes. Doing the removal in
build_extensions() instead works.
This went unnoticed because the upstream issue in distutils
(https://bugs.python.org/issue5755) was recently fixed in Py3.6.6 and
3.7.0; but this still affects Py3.5 and Py3.6.{0-5}.
Corrects #11965.
PR Summary
PR Checklist