Skip to content

Typo in mlab.cohere #10003

New issue
New issue
Closed
#10004
Closed
Typo in mlab.cohere#10003
#10004
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.status: confirmed bug
Milestone
 
v2.1.2
@duncanmmacleod

Description

@duncanmmacleod
duncanmmacleod
opened on Dec 14, 2017

There is a critical typo in mlab.cohere introduced by 1504540:

matplotlib/lib/matplotlib/mlab.py

Lines 1341 to 1347 in 49d5ced

Pxx, f = psd(x, NFFT, Fs, detrend, window, noverlap, pad_to, sides,
scale_by_freq)
Pyy, f = psd(y, NFFT, Fs, detrend, window, noverlap, pad_to, sides,
scale_by_freq)
Pxy, f = csd(x, y, NFFT, Fs, detrend, window, noverlap, pad_to, sides,
scale_by_freq)
Cxy = np.abs(Pxy) ** 2 / (Pxx * Pxy)

There is a critical typo in mlab.cohere, the final line should read:

    Cxy = np.abs(Pxy) ** 2 / (Pxx * Pyy)

[i.e. a single character change Pxy -> Pyy].

Metadata

Metadata

Assignees

No one assigned

    Labels

    Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.status: confirmed bug

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions