Skip to content

Add documentation for set_rlim #10704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dstansby opened this issue Mar 7, 2018 · 3 comments · Fixed by #12300
Closed

Add documentation for set_rlim #10704

dstansby opened this issue Mar 7, 2018 · 3 comments · Fixed by #12300
Labels
Documentation Good first issue Open a pull request against these issues if there are no active ones! topic: polar
Milestone
v3.1.0

Comments

@dstansby
Copy link
Member

dstansby commented Mar 7, 2018

The polar axes method set_rlim currently has no documentation, and a unhelpful *args, **kwargs signature. It would be good to add some documentation, and if possible make the signature a bit more clear. (xref #10654)
@dstansby dstansby added Documentation topic: polar Good first issue Open a pull request against these issues if there are no active ones! labels Mar 7, 2018
@tacaswell tacaswell added this to the v2.2.1 milestone Mar 7, 2018
@AdamsonMA
Copy link

Is this issue still open? If so, I am interested in fixing the issue to get more involved with the project.

@jklymak
Copy link
Member

jklymak commented Mar 8, 2018

@AdamsonMA That'd be great!

@jklymak jklymak modified the milestones: v2.2.1, v3.0 Mar 12, 2018
@AdamsonMA
Copy link

I'll have the documentation for the set_rlim and other methods in the polar graph done tomorrow. However, I saw that the set_rlim function only has the ability to call two other methods within the class, and does not make any computations itself. Perhaps the method could allow the possibility of calling all of the setter methods, just be deleted for redundancy, or left in the code?

@tacaswell tacaswell modified the milestones: v3.0, v3.1 Aug 11, 2018
@jklymak jklymak mentioned this issue Oct 2, 2018
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Good first issue Open a pull request against these issues if there are no active ones! topic: polar
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging a pull request may close this issue.

API: Polar: allow flipped y/rlims.... jklymak/matplotlib
4 participants
@tacaswell @jklymak @dstansby @AdamsonMA