Skip to content

Home button together with tight_layout sometimes doesn't work #10989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fredrik-1 opened this issue Apr 8, 2018 · 4 comments
Closed

Home button together with tight_layout sometimes doesn't work #10989

fredrik-1 opened this issue Apr 8, 2018 · 4 comments
Labels
status: confirmed bug status: inactive Marked by the “Stale” Github Action

Comments

@fredrik-1
Copy link
Contributor

Bug summary
When pushing the home button the subplots sometimes get larger and larger, sometimes smaller and smaller and sometimes stay in the correct size. The code and procedure below trigger it for me everytime in both QT5 and tkinter but other use cases has also triggered it but much more randomly

import matplotlib.pyplot as plt
import numpy as np

fig=plt.figure(1)
fig.clf()
N=3
for i in range(N*N):
     fig.add_subplot(N,N,i+1).plot(np.random.randn(10000))
fig.set_tight_layout(True)
  1. zoom in one of the subplots
  2. push the home button
  3. resize the plot window
  4. push the home button
  5. push the home more times get an even worse plot

(it can also be done with the backward and forward buttons).

The subplot plots starts to overlap for me with this procedure.

A new draw or zoom results in a correct plot which I found kind of weird.

I tried to figure out what causes the problem and I think that the problem is in
backend_bases , line 3100, _update_view()

 def _update_view(self):
        """Update the viewlim and position from the view and
        position stack for each axes.
        """
        nav_info = self._nav_stack()
        if nav_info is None:
            return
        # Retrieve all items at once to avoid any risk of GC deleting an Axes
        # while in the middle of the loop below.
        items = list(nav_info.items())
        for ax, (view, (pos_orig, pos_active)) in items:
            ax._set_view(view)
            # Restore both the original and modified positions
            ax._set_position(pos_orig, 'original')
            ax._set_position(pos_active, 'active')
        self.canvas.draw_idle()

and due to the lines

ax._set_position(pos_orig, 'original')
ax._set_position(pos_active, 'active')

The home button seems to (almost) work as expected if those lines are commented out. Almost because the view seems to change a little when I push the home button the first time.

Matplotlib 2.2.2
python 3.6.3
IPython 6.1.0
windows 10
installed with conda
@fredrik-1 fredrik-1 changed the title Home button together with tight_layout sometimes don't work Home button together with tight_layout sometimes doesn't work Apr 8, 2018
@fredrik-1
Copy link
Contributor Author

The problem seems to be that
ax.get_subplotspec().get_topmost_subplotspec().get_position(fig)
that is used in the tight_layout calculation is not equal to the axis position in the "home stack" (that is set as the ax position with the home button) and that result in an incorrect tight_layout calculation. I am not sure how to fix that in a good why but it seems to work to add self.canvas.figure.tight_layout() before self.canvas.draw_idle() in the code above. That result in bad but consistent parameters in my case and the following drawing works as expected.

I am not sure if the solution is general though and it feels like it is the wrong place to use figure.

def _update_view(self):
        """Update the viewlim and position from the view and
        position stack for each axes.
        """
        nav_info = self._nav_stack()
        if nav_info is None:
            return
        # Retrieve all items at once to avoid any risk of GC deleting an Axes
        # while in the middle of the loop below.
        items = list(nav_info.items())
        for ax, (view, (pos_orig, pos_active)) in items:
            ax._set_view(view)
            # Restore both the original and modified positions
            ax._set_position(pos_orig, 'original')
            ax._set_position(pos_active, 'active')
        if self.canvas.figure.get_tight_layout():
            self.canvas.figure.tight_layout()
        self.canvas.draw_idle()

@fredrik-1
Copy link
Contributor Author

Any comments about this? Should I write a pull request? I don't really know what it can break.

fredrik-1 added a commit to fredrik-1/matplotlib that referenced this issue Apr 15, 2018
@fredrik-1
fix home button matplotlib#10989
56c3a92
fredrik-1 added a commit to fredrik-1/matplotlib that referenced this issue Apr 19, 2018
@fredrik-1
fix home button matplotlib#10989
e5f15f3
fredrik-1 added a commit to fredrik-1/matplotlib that referenced this issue May 11, 2018
@fredrik-1
fix home button matplotlib#10989
7952e27
This was referenced Jul 22, 2018
Closed
Closed
@github-actions
Copy link

github-actions bot commented May 3, 2023

This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label May 3, 2023
@github-actions github-actions bot added the status: closed as inactive Issues closed by the "Stale" Github Action. Please comment on any you think should still be open. label Jun 2, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2023
@tacaswell
Copy link
Member

I can not reproduce this any more.

I do not think it is worth bisecting to when we fixed it, but from the linked issues I suspect #11754

@rcomer rcomer removed the status: closed as inactive Issues closed by the "Stale" Github Action. Please comment on any you think should still be open. label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: confirmed bug status: inactive Marked by the “Stale” Github Action
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tacaswell @timhoffm @rcomer @fredrik-1