Skip to content

Really deprecate Patches.xy? #11322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
timhoffm opened this issue May 27, 2018 · 4 comments
Closed

Really deprecate Patches.xy? #11322

timhoffm opened this issue May 27, 2018 · 4 comments
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Milestone
v3.0.0

Comments

@timhoffm
Copy link
Member

Part of #11299 deprecates the property Patches.xy.

I assume this was based on the existing docstring

Set/get the vertices of the polygon. This property is
provided for backward compatibility with matplotlib 0.91.x
only. New code should use
:meth:~matplotlib.patches.Polygon.get_xy and
:meth:~matplotlib.patches.Polygon.set_xy instead.

That docstring is 10 years old, and I'm not sure if we really want to deprecate the property. In many places I would actually favor properties over getters/setters.
@anntzer
Copy link
Contributor

anntzer commented May 27, 2018 •
edited
Loading

I'm fine with restoring it. But please reword the docstring then :)

@ImportanceOfBeingErnest
Copy link
Member

This is surely one of the many cases where independent of what the docs say, people are just using it. Hence when removing such property/attribute that people do use, there should be some reason to do so.

Is there any such reason? If not, I would personally also favour keeping it.

@dstansby dstansby added this to the v3.0 milestone May 28, 2018
@tacaswell
Copy link
Member

👍 on un-deprecating and changing the doc-string as required.

@anntzer
Copy link
Contributor

anntzer commented May 28, 2018

(I honestly just saw the docstring and didn't think more than "sure, why not, there's another way to do it so let's kill the duplicate".)

@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label May 28, 2018
@timhoffm timhoffm mentioned this issue May 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
5 participants
@tacaswell @anntzer @timhoffm @dstansby @ImportanceOfBeingErnest