Skip to content

Possibly excessive transform creation #12031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
efiring opened this issue Sep 6, 2018 · 5 comments
Open

Possibly excessive transform creation #12031

efiring opened this issue Sep 6, 2018 · 5 comments
Labels
keep Items to be ignored by the “Stale” Github Action Performance

Comments

@efiring
Copy link
Member

efiring commented Sep 6, 2018

Follow-up to #11972, which solves a memory leak, but leaves the question of whether we can improve performance by reducing the number of transform instantiations.

It was pointed out that simply moving the cursor in an otherwise static plot is enough to cause calls to Transform.set_children, which occurs when transforms are chained or blended.

@QuLogic
Copy link
Member

QuLogic commented Sep 6, 2018

When creating composite transforms, would it work if we checked parents and returned the one that already existed and contained the two transforms? I think these are immutable, and there's already some shortcuts to avoid adding redundant IdentityTransforms.

@github-actions
Copy link

This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label May 15, 2023
@github-actions github-actions bot added the status: closed as inactive Issues closed by the "Stale" Github Action. Please comment on any you think should still be open. label Jun 14, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2023
@efiring
Copy link
Member Author

efiring commented Jun 14, 2023

@anntzer You have worked on transforms quite recently; do you know whether this issue is now obsolete? If it isn't, I'm tempted to reopen it.

@anntzer anntzer reopened this Jun 14, 2023
@anntzer
Copy link
Contributor

anntzer commented Jun 14, 2023

I don't think it's obsolete.
I had somehow missed @QuLogic's suggestion above; it should be reasonably doable to implement (just need a lot of fiddling with weakrefs in the caches...) and even though it is not absolutely clear it will help, it does seems worth trying.

@QuLogic QuLogic removed status: inactive Marked by the “Stale” Github Action status: closed as inactive Issues closed by the "Stale" Github Action. Please comment on any you think should still be open. labels Jun 14, 2023
Copy link

This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Sep 23, 2024
@jklymak jklymak added keep Items to be ignored by the “Stale” Github Action and removed status: inactive Marked by the “Stale” Github Action labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep Items to be ignored by the “Stale” Github Action Performance
Projects
None yet
Development

No branches or pull requests

4 participants