-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Init calls subclass method pattern #12220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
A lot of these are explicitly here to provide customization points of the initialization to subclasses... I wouldn't overly worry about them unless they are actually problematic (which can definitely happen). |
I agree with @anntzer, many of the cases where we have this are using setters (you have the same problem with properties) that cause non-trivial internal state change. We both want to override those things in sub-classes and to set up defaults in The advise to use composition is well meaning, but I don't think practical for us.... |
For setters/properties, it would be work to define the subclass attributes before calling the super init. Would that be a reasonable pattern? |
This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help! |
Let's not follow up on this for now. |
We have a lot of places with the init-calls-subclass pattern.
This cause problems if the subclass method relies on subclass attributes that have not yet been set up.
I actually ran into the issue in #12215.
The text was updated successfully, but these errors were encountered: