Skip to content

More tests ConciseDateFormatter needed #15182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jklymak opened this issue Sep 4, 2019 · 10 comments · Fixed by #16215
Closed

More tests ConciseDateFormatter needed #15182

jklymak opened this issue Sep 4, 2019 · 10 comments · Fixed by #16215
Assignees
Labels
Good first issue Open a pull request against these issues if there are no active ones! topic: date handling topic: testing
Milestone

Comments

@jklymak
Copy link
Member

jklymak commented Sep 4, 2019

Would we need to draw the conclusion that ConciseDateFormatter is not sufficiently tested, or is this code path too non-standard?

Originally posted by @ImportanceOfBeingErnest in #15181 (comment)

Indeed the format and zero_format options should get tests, including checks if they are wrong-sized, etc. Promise to do this ASAP.... or happy to help a newer contributor through writing these tests.

@jklymak jklymak self-assigned this Sep 4, 2019
@jklymak jklymak added this to the v3.3.0 milestone Sep 4, 2019
@tacaswell tacaswell added the Good first issue Open a pull request against these issues if there are no active ones! label Sep 4, 2019
@sameshl
Copy link
Contributor

sameshl commented Sep 8, 2019

@jklymak I would love to take this up

@jklymak
Copy link
Member Author

jklymak commented Sep 8, 2019

That would be great! Let us know if you need guidance.

@abhinuvpitale
Copy link
Contributor

@sameshl are you on this, or else I could get started on this.

@sameshl
Copy link
Contributor

sameshl commented Oct 20, 2019

@abhinuvpitale You can get started on this.

@abhinuvpitale
Copy link
Contributor

@jklymak I need to add the tests in the test_dates.py right?
A little guidance on the test content would be helpful.

@jklymak
Copy link
Member Author

jklymak commented Oct 25, 2019

That’s right test_dates.py. The content would be checking that the formatter makes the correct format if you change format and zero_format

@stevenjlm
Copy link

Since this thread seems kind of dead, I wrote 2 tests and have code for it (it's on a branch on my forked copy of matplotlib); however, when I run tests locally, a lot of them fail because dateutil throws a deprecation warning. Since this is not matplotlib, should I ignore it? Or should I do something?

@jklymak
Copy link
Member Author

jklymak commented Jan 14, 2020

I guess that depends on why dateutil is throwing a deprecation warning?

@stevenjlm
Copy link

Full trace:
trace.txt
The relevant line is,
DeprecationWarning: fractions.gcd() is deprecated. Use math.gcd() instead.

@jklymak
Copy link
Member Author

jklymak commented Jan 14, 2020

Thanks. That’s dateutils issue so fee free to ignore it. Or report it to them if you can make a non matplotlib mi nimble example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Open a pull request against these issues if there are no active ones! topic: date handling topic: testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants