-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
More tests ConciseDateFormatter
needed
#15182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@jklymak I would love to take this up |
That would be great! Let us know if you need guidance. |
@sameshl are you on this, or else I could get started on this. |
@abhinuvpitale You can get started on this. |
@jklymak I need to add the tests in the |
That’s right |
Since this thread seems kind of dead, I wrote 2 tests and have code for it (it's on a branch on my forked copy of |
I guess that depends on why |
Full trace: |
Thanks. That’s dateutils issue so fee free to ignore it. Or report it to them if you can make a non matplotlib mi nimble example. |
Originally posted by @ImportanceOfBeingErnest in #15181 (comment)
Indeed the
format
andzero_format
options should get tests, including checks if they are wrong-sized, etc.Promise to do this ASAP.... or happy to help a newer contributor through writing these tests.The text was updated successfully, but these errors were encountered: