-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DivergingNorm is a misleading name #15336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I habe a bit of a hard time finding a good name. Best so far is:
The original Maybe it would be best to actually implement a more general
would then be
for the list, we would divide the [0...1] range into equal segments to determine the target value of a given limit. If the generalization seems too complicated for 3.2, we could still add the |
I called it Or |
I'd be OK with a general |
In 2011 @Tillsten wrote In 2013 @joferkington simplified this and called it In 2014 @phobson Created a PR with a mixture of both solutions under the name This was taken over by @dopplershift in #4666 under the name
@tacaswell was "sold on Diverging Norm" (2015) That has gone stale, until being picked up in #12419 by @jklymak, not changing the name that was previously agreed upon. I'm summarizing this here such that discussion wouldn't need rerun through the same circles it already has years ago. Also I would like to mention that there are already a few stackoverflow answers actively using |
Example usecases for PiecewiseLinearNorm with more than two segments.@jklymak could be tuned in a way that the large part of the colormap describes the scale [-1, 1], but you keep some range for [-10, 1] and [1, 10]. Also, if you know to have data more or less at different levels such as (cross-section) You could increase the sensitivity around -1 and 1 and shrink the color range used for the uninteresting [-0.9, 0.9] data. |
I deal with "red" data sets like that all the time. For something like that, I think its preferable to solve the problem via analysis (typically filtering), rather than fiddle with a very non-traditional color mappings. Just think about the figure caption you'd have to include with a plot like that: "Note that the colormapping has three linear ramps, the first from -1.2 to -0.8 encompassing 1/3 of the colors, the second from -0.8 to 0.8 encompassing the second third, and the third from 0.8 to 1.2 encompassing the last third of the colormap". I think it'd get a rough time in review. But, if you want to take a crack at making |
Minor note on nomenclature: PiecewiseLinearNorm probably should be called LinearSplineNorm unless it allows discontinuities. I haven't checked, but I think the various versions in PRs for these things have all been continuous. |
|
@timhoffm would you like to put in a PR to deprecate the DivergingNorm name and replace it with TwoSlopeNorm? Or would you prefer that I do it? |
@ImportanceOfBeingErnest Thank you for your very through tracing through the history of this discussion! |
DivergingNorm was introduced when #12419 was merged. Discussion of #15333 on the Sept. 24, 2019 call led to the conclusion that the "DivergingNorm" name was an unfortunate and misleading choice. We need to select a better name ASAP, preferably before the 3.2 release, so that DivergingNorm can be deprecated and replaced before it is in wide use.
The text was updated successfully, but these errors were encountered: