Skip to content

Deprecate ConnectionStyle._Base and ArrowStyle._Base #18713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
anntzer opened this issue Oct 11, 2020 · 3 comments
Open

Deprecate ConnectionStyle._Base and ArrowStyle._Base #18713

anntzer opened this issue Oct 11, 2020 · 3 comments
Labels
keep Items to be ignored by the “Stale” Github Action Maintenance

Comments

@anntzer
Copy link
Contributor

anntzer commented Oct 11, 2020

Describe the issue

Summary

Private base classes are problematic from a documentation PoV (see lengthy discussion at #15503). In the specific case of ConnectionStyle._Base and ArrowStyle._Base, the base class could be eliminated by moving its logic to the caller side, as was done for BoxStyle._Base in #17737. This would make it easier for third parties to implement their own ConnectionStyles/ArrowStyles as plain classes with a __call__ method.

Proposed fix

Deprecate ConnectionStyle._Base and ArrowStyle._Base, with the same logic-moving as in #17737.
@github-actions
Copy link

This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Aug 25, 2023
@anntzer anntzer added keep Items to be ignored by the “Stale” Github Action and removed status: inactive Marked by the “Stale” Github Action labels Aug 25, 2023
@QuLogic
Copy link
Member

QuLogic commented Aug 25, 2023

This is also weird for typing purposes, where we say we accept ConnectionStyle, except that none of the actual style classes derive from it, but from the hidden _Base.

@QuLogic
Copy link
Member

QuLogic commented Aug 31, 2023

Also related is that _Style.register checks issubclass(style, cls._Base), which one can't do without accessing the private class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keep Items to be ignored by the “Stale” Github Action Maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@QuLogic @anntzer