-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
More consistent handling of 'None' vs. 'none' #19300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Aren't there places where they mean different things? i.e. This is the case at very least for |
This is about capitalization of strings |
Oops! Missed that entirely, sorry for noise. |
I have definitely encountered this in several places (including markers). For now I've been erring on the side of accepting both I'd add my vote for |
I was playing around with this and noted two things:
|
Yes it’s a bit of a mess. |
Summary
The strings
'None'
vs'none'
are not handled consistently:'None'
(xref Cleanup code for format processing #19291 (comment)). - Maybe other places too.'None'
,'none'
(and sometimes also other capitalizations).'None'
in our code base.Proposed fix
Aim at making the API more consistent by:
'none'
because most other named strings are lowercase. And it's a step further away fromNone
, which may help making it more clear that those two are different.Note @brunobeltran You might stumble over these inconsistencies when formalizing types.
The text was updated successfully, but these errors were encountered: