Skip to content

[MNT]: Should set_size_inches be updated to use device_pixel_ratio? #21090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anntzer opened this issue Sep 16, 2021 · 1 comment
Closed

[MNT]: Should set_size_inches be updated to use device_pixel_ratio? #21090

anntzer opened this issue Sep 16, 2021 · 1 comment
Labels
Maintenance
Milestone
v3.5.0

Comments

@anntzer
Copy link
Contributor

anntzer commented Sep 16, 2021

Summary

set_size_inches currently uses

matplotlib/lib/matplotlib/figure.py

Line 2659 in eecdbbc

dpi_ratio = getattr(canvas, '_dpi_ratio', 1)

I haven't actually tried, but I wonder if that was missed in #19126, and should be changed to canvas.device_pixel_ratio?

(Likewise, backend_macosx.py would likely need to be updated in the same manner?)

Proposed fix

No response
@QuLogic
Copy link
Member

QuLogic commented Sep 28, 2021

It does appear to be wrong. The figure is double-sized for what was requested, if you pull it from a hidpi back to regular screen.

QuLogic added a commit to QuLogic/matplotlib that referenced this issue Sep 28, 2021
@QuLogic
Fix set_size_inches on HiDPI screens
7267d23 
This passes physical pixels to the backend, as it will be more accurate
due to the int-cast.

Fixes matplotlib#21090
QuLogic added a commit to QuLogic/matplotlib that referenced this issue Sep 29, 2021
@QuLogic
Fix set_size_inches on HiDPI screens
a0a1294 
This passes physical pixels to the backend, as it will be more accurate
due to the int-cast.

Fixes matplotlib#21090
QuLogic added a commit to QuLogic/matplotlib that referenced this issue Sep 29, 2021
@QuLogic
Fix set_size_inches on HiDPI screens
38691d7 
This passes physical pixels to the backend, as it will be more accurate
due to the int-cast.

Fixes matplotlib#21090
QuLogic added a commit to QuLogic/matplotlib that referenced this issue Sep 29, 2021
@QuLogic
Fix set_size_inches on HiDPI screens
9dc00b4 
This passes physical pixels to the backend, as it will be more accurate
due to the int-cast.

Fixes matplotlib#21090
QuLogic added a commit to QuLogic/matplotlib that referenced this issue Oct 15, 2021
@QuLogic
Fix set_size_inches on HiDPI screens
4635702 
This passes physical pixels to the backend, as it will be more accurate
due to the int-cast.

Fixes matplotlib#21090
QuLogic added a commit to QuLogic/matplotlib that referenced this issue Oct 15, 2021
@QuLogic
Fix set_size_inches on HiDPI screens
56fe546 
This passes physical pixels to the backend, as it will be more accurate
due to the int-cast.

Fixes matplotlib#21090
@QuLogic QuLogic added this to the v3.5.0 milestone Oct 20, 2021
ccaprani pushed a commit to ccaprani/matplotlib that referenced this issue Jan 23, 2023
@QuLogic @ccaprani
Fix set_size_inches on HiDPI screens
ba2c930 
This passes physical pixels to the backend, as it will be more accurate
due to the int-cast.

Fixes matplotlib#21090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.5.0
Development

No branches or pull requests
2 participants
@QuLogic @anntzer