Skip to content

[MNT]: Close subplot_parameters window when main figure closes #21679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
greglucas opened this issue Nov 19, 2021 · 1 comment · Fixed by #21681
Closed

[MNT]: Close subplot_parameters window when main figure closes #21679

greglucas opened this issue Nov 19, 2021 · 1 comment · Fixed by #21681
Assignees
@QuLogic
Labels
Maintenance
Milestone
v3.5.1

Comments

@greglucas
Copy link
Contributor

Summary

If you click the subplot parameters button from the toolbar, a new window pops up. If you then close the main figure window, the subplot parameters window will still be there and keep the session alive. I would expect the main figure window to close the subplot parameters pop up as well on close. (same experience on macosx and qt5agg)

Proposed fix

Keep a child reference to the subplot parameters window around that we can then close automatically for the user?
@anntzer
Copy link
Contributor

anntzer commented Nov 19, 2021 •
edited
Loading

Probably you can do something like connecting to close_event?

@anntzer anntzer mentioned this issue Nov 19, 2021
Merged
6 tasks
@QuLogic QuLogic self-assigned this Nov 19, 2021
@QuLogic QuLogic linked a pull request Nov 19, 2021 that will close this issue
Bind subplot_tool more closely to target figure. #21681
Merged
6 tasks
@QuLogic QuLogic added this to the v3.5.1 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QuLogic QuLogic

Labels
Maintenance
Projects
None yet
Milestone
v3.5.1
Development

Successfully merging a pull request may close this issue.

Bind subplot_tool more closely to target figure. anntzer/matplotlib
3 participants
@QuLogic @anntzer @greglucas