Skip to content

[Bug]: Configure subplots dialog freezes for TkAgg with toolmanager #22092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
StefRe opened this issue Jan 3, 2022 · 7 comments
Closed

[Bug]: Configure subplots dialog freezes for TkAgg with toolmanager #22092

StefRe opened this issue Jan 3, 2022 · 7 comments
Labels
GUI: tk status: confirmed bug
Milestone
v3.6.0

Comments

@StefRe
Copy link
Contributor

StefRe commented Jan 3, 2022

Bug summary

When using the toolmanager toolbar with the Tk backend the "Configure subplots" dialog works at first but then freezes.

Code for reproduction

import matplotlib.pyplot as plt
plt.rcParams['toolbar'] = 'toolmanager'
plt.matplotlib.use('tkagg')

plt.plot((1,2))
plt.show()

Actual outcome

Open the dialog and move some sliders - after a short while the dialog freezes.

Expected outcome

Dialog should not freeze.

Additional information

It works fine without the toolmanager.

Operating system

Windows

Matplotlib Version

3.5.1

Matplotlib Backend

TkAgg

Python version

3.8.2

Jupyter version

Installation

pip
@richardsheridan
Copy link
Contributor

I can confirm this bug and also it seems have been introduced between 3.3.4 and 3.4.0rc1.

@gtoombs-microsaas
Copy link

Similar situation, different pathway: if you copy the slider example but let both of the sliders go out of scope, the sliders will stop working.

If either of the sliders is kept in scope, both sliders will continue to function.

@QuLogic
Copy link
Member

QuLogic commented Feb 16, 2022

That's unrelated; all widgets must be kept in scope to remain functional. It says so on every widget.

@QuLogic
Copy link
Member

QuLogic commented May 5, 2022

It seems to be working for me; maybe fixed by one of your recent PRs, @richardsheridan? Or perhaps it is Windows only?

@richardsheridan
Copy link
Contributor

Looks like it was fixed by @anntzer in b896076 as part of #21992. I don't think it's totally obvious why it was fixed, which presumably also makes the fix hard to backport to 3.5.x... I recommend closing this issue unless someone has a solid plan to backport a patch.

@richardsheridan
Copy link
Contributor

For good measure I also bisected the bug introduction back to b9d9049 in #18226. Also not very helpful in proposing a backportable patch!

@QuLogic
Copy link
Member

QuLogic commented May 5, 2022

Hmm, okay then, I think we can close this.

@QuLogic QuLogic closed this as completed May 5, 2022
@QuLogic QuLogic added this to the v3.6.0 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GUI: tk status: confirmed bug
Projects
None yet
Milestone
v3.6.0
Development

No branches or pull requests
4 participants
@QuLogic @richardsheridan @StefRe @gtoombs-microsaas