-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Extract the development docs from this repository #22866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Do we want to put this in |
Originally I thought |
Makes sense. It does not fit into We may need a place to document which repositories are used for which parts of the docs. - Should this be in a separate repo as well? 😜 |
Maybe just in the docs themselves? |
Could maybe go in the dev guide for doc contributions since "where is this thing I want to change?" is a not infrequent new contributor question. |
I personally think we should have as few repos as possible. i.e. one tied to releases, and the other not tied to anything. mpl_third_party is a bit different as it has its own review and build pipeline. |
Currently we are pulling the artifacts for our docs from 14 different repos (see If we focus just on the core library docs we have:
I've been thinking about security for unrelated reasons recently. I am not concerned about what people we know and have given access to are going to do, however I am concerned about what someone who gets control of one of our accounts might do which is why I want to restrict write permissions on the goverance and very repos that are the source for the high-traffic parts of our website. I do not think there is anything we really want to merge together, we are already paying the complexity cost of "more that one" at the caddy configuration level, and wanting to have different review/merge rules on https://matplotlib.org and the development guide I think we should go with (just) one more repo and include the above in the devel guide as a part of how to work on the docs. |
OK, that makes sense. maybe just leave it open to be more than just "dev guide" in case we want other docs not tied explicitly to the release cycle? |
That seems correct to me, but no better term is coming to mind quickly. I would also want to move the communication guidelines out of governance to the new repo along with guides/templates on how to handle common situations with (new) contributors ("we do not assign issues, just start working", "congrats on your first PR, hope to here from you again!", "this better handled on discourse", "can you please include a minimal running example + version numbers", "your local installation is broken, uninstall everything and try using just 1 (one) package manager", etc), the triage guide, the PR review guide, etc, the meta-doc on docs, etc. In our usual way, https://matplotlib.org/stable/devel/index.html is "contributing-and-maintaining-and-community-guide" is too long. |
Cause this is coming up in #27386, over the past year the the dev docs have been updated and gitwash stripped out (thanks @melissawm!). I'd prefer #27265 to go in before we move things (especially since it includes a 'where are docs section' I can flesh out).
Broadly speaking, the version independent docs are consolidated to:
The plan for resources was/is that it should get something like the third-party-package repo so it sort of doesn't matter, and I think a follow up PR to a migration is updating cross links using intersphinx (which there's a configuration we can use to treat it as one big doc so none of the links break so we may not even need to). ETA: the users/project docs are also in a weird space in that for the most part I think the contents of those docs should be very difficult to change - it's mission/code of conduct/licence/history/credits - w/o major discussion. Like our CoC or mission shouldn't be changeable by way of one approval unless it's like a typo/formatting fix. |
I don't think we need to move anything - simply point |
Ping @QuLogic for an opinion on if either of the above are doable. |
I feel splitting dev instructions out into a separate repo decouples them too much, and adds extra burden (separate repo to configure and handle). Primary requirement: The dev instructions should be updated contiuously. Typically dev happens on main and instructions how to work there are relevant, not the dev instuctions that were active during the latest release. I see two possible ways to achieve this:
|
On the server, there are two options:
We would need to be a bit careful if I don't think |
I think setting a couple of the high profile links to contribute to the dev docs may catch most of the cases if we want something on the simple side:
|
Probably a redirect is more appropriate, unless all the links in devel are relative, which I doubt they are.
I think we need to be careful to do this anyways, so I don't think thats too strong an objection.
I think that is OK, and a strong argument for a redirect versus rewrite. If you want to go to |
Here is the followup PR from the meeting discussion: matplotlib/matplotlib.org#36 |
We have historically built all of our documentation from the sphinx source in the main matplotlib/matplotlib repo (this one). We would then host this by unpacking the result of the build at the top level of website + into a version specific sub-folder. We would also rely on
While this served us well for over a decade, over the past few years we have slowly started to pull things apart. The goal is to ultimately de-couple the version independent parts of the documentation (which should be re-published as soon as they are update) from the version-specific docs (which should be Steps we have already taken so far:
The next thing we should pull out into its own repository is the content under https://matplotlib.org/stable/devel/index.html . We probably should copy-paste the GHA/sphinx configuration from the governance repo and update the rst in that framework.
We should do this as a second step after we finish @noatamir 's update of that content (to make it easier to review the changes at each step).
The text was updated successfully, but these errors were encountered: