Skip to content

[MNT]: Deprecate ConnectionStyle._Base and ArrowStyle._Base #23238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
anntzer opened this issue Jun 10, 2022 · 1 comment
Open

[MNT]: Deprecate ConnectionStyle._Base and ArrowStyle._Base #23238

anntzer opened this issue Jun 10, 2022 · 1 comment
Labels
Maintenance

Comments

@anntzer
Copy link
Contributor

anntzer commented Jun 10, 2022

Summary

As done in #17737/#23237, it should be possible to get rid of the (private, but currently compulsory) base class and instead simply say that a connectionstyle/arrowstyle instance needs to be callable with a certain signature.

Proposed fix

Repeat #17737/#23237, but for ConnectionStyle._Base and ArrowStyle._Base.
@timhoffm
Copy link
Member

If we had typing already, I'd have suggested to use a Protocol here. Maybe something to keep in mind for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anntzer @timhoffm