Skip to content

[CI]: eslint failure #25251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
scottshambaugh opened this issue Feb 18, 2023 · 1 comment · Fixed by #25262
Closed

[CI]: eslint failure #25251

scottshambaugh opened this issue Feb 18, 2023 · 1 comment · Fixed by #25262
Labels
CI: testing CI configuration and testing
Milestone
v3.7.1

Comments

@scottshambaugh
Copy link
Contributor

scottshambaugh commented Feb 18, 2023 •
edited
Loading

Summary

Recent PRs are failing eslint linter checks with the following:

Run reviewdog/action-eslint@v1
Run $GITHUB_ACTION_PATH/script.sh
🐶 Installing reviewdog ... https://github.com/reviewdog/reviewdog
 Running `npm install` to install eslint ...
eslint version:
/home/runner/work/_actions/reviewdog/action-eslint/v1/script.sh: 20: Unknown: not found
 Running eslint with reviewdog 🐶 ...
  /home/runner/work/_actions/reviewdog/action-eslint/v1/script.sh: 23: Unknown: not found
reviewdog: failed to unmarshal rdjson (DiagnosticResult): proto: syntax error (line 1:1): unexpected token 
Error: Process completed with exit code 1.

Looks related to this: reviewdog/action-eslint#152

Proposed fix

The above issues proposes a workaround with:

      - uses: actions/setup-node@v3
         with:
           node-version: '18.13'
           cache: 'yarn'

However I’m unclear if pinning that version is best practice.
@scottshambaugh scottshambaugh added Maintenance CI: testing CI configuration and testing and removed Maintenance labels Feb 18, 2023
@robrighter
Copy link
Contributor

robrighter commented Feb 19, 2023 •
edited
Loading

I feel like it would be reasonable to apply this workaround for now and also create a separate issue to remove the workaround when v9 support is added.

@robrighter robrighter mentioned this issue Feb 19, 2023
Merged
6 tasks
@greglucas greglucas mentioned this issue Feb 19, 2023
Merged
6 tasks
@QuLogic QuLogic added this to the v3.7.1 milestone Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI: testing CI configuration and testing
Projects
None yet
Milestone
v3.7.1
Development

Successfully merging a pull request may close this issue.

CI: Pin reviewdog eslint to use node 18.13 greglucas/matplotlib
3 participants
@robrighter @QuLogic @scottshambaugh