Skip to content

[ENH]: Support for \boldsymbol #25643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oscargus opened this issue Apr 7, 2023 · 5 comments · Fixed by #25661
Closed

[ENH]: Support for \boldsymbol #25643

oscargus opened this issue Apr 7, 2023 · 5 comments · Fixed by #25661

Comments

@oscargus
Copy link
Member

oscargus commented Apr 7, 2023

Problem

Once #25359 is merged, it should be rather straightforward to add support for \boldsymbol which basically does the same thing as \mathbfit but is maybe a more standard solution.

Proposed solution

Some inspiration can be taken from #22173 on how to add a new parsing element, although QuotedString should (most likely) not be used.

@devRD
Copy link
Contributor

devRD commented Apr 8, 2023

Hi @oscargus,

I have a working patch for boldsymbol in my local repository. Since #25359 is a dependency, I am unsure about opening a new PR.

Also, for generating the tests for boldsymbol, does it need all tests for the baseline_images, or similar to #22173 adding a lightweight test is fine?

@oscargus
Copy link
Member Author

oscargus commented Apr 9, 2023

Great!

I think a lightweight test is enough.

Hopefully, #25359 is merged soon, so maybe one can wait for a bit before adding it? It is possible to open a new PR as well and just state that it depends on #25359.

@devRD
Copy link
Contributor

devRD commented Apr 11, 2023

As mentioned in the linked PR, these changes currently do not build without PR #25359.

@ksunden
Copy link
Member

ksunden commented Jun 7, 2023

Xref #1366

Discussion there seems to have centered around "do we wish to include amsmath things in the mathtext implementation or keep it 'pure latex', for simplicity and scoping".

That said, the barrier for amsmath is breached by \genfrac and \binom already, so that could be an argument for including \boldsymbol

However, the behavior of \boldsymbol is not quite the same as bfit as noted by @devRD here.

My personal prior would be that if \boldsymbol is included, it should behave as close to the latex behavior as possible, and thus is not as simple as aliasing bfit, though the implementation may mirror bfit.

@oscargus
Copy link
Member Author

oscargus commented Jun 7, 2023

There are more things that are from ams and other packages (especially symbols). I'd say add what is useful.

@QuLogic QuLogic added this to the v3.8.0 milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants