Skip to content

[MNT]: Switch docs/examples to use Noto Sans CJK instead of WenQuanYi Zen Hei as CJK font #25724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anntzer opened this issue Apr 19, 2023 · 4 comments · Fixed by #25726
Closed

[MNT]: Switch docs/examples to use Noto Sans CJK instead of WenQuanYi Zen Hei as CJK font #25724

anntzer opened this issue Apr 19, 2023 · 4 comments · Fixed by #25726
Labels
Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues Good first issue Open a pull request against these issues if there are no active ones! Maintenance topic: text/fonts
Milestone
v3.8.0

Comments

@anntzer
Copy link
Contributor

anntzer commented Apr 19, 2023

Summary

Some examples use WenQuanYi Zen Hei as CJK (chinese/japanese/korean) font, but it is less convenient to install on macos (#16112); other examples already rely on Noto Sans CJK, which is still available on Homebrew, so we could just as well always rely on that font instead.

Proposed fix

Replace usage of WenQuanYi Zen Hei by Noto Sans CJK in the docs/galleries.
@QuLogic QuLogic added Good first issue Open a pull request against these issues if there are no active ones! Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues labels Apr 19, 2023
@tacaswell tacaswell added this to the v3.8.0 milestone Apr 19, 2023
@anntzer anntzer mentioned this issue Apr 19, 2023
Open
@Ayush-mishra-0-0
Copy link

How can I contribute here? Can you plz help?

@ksunden ksunden linked a pull request Apr 25, 2023 that will close this issue
Replace usage of WenQuanYi Zen Hei by Noto Sans CJK #25726
Merged
3 tasks
@ksunden
Copy link
Member

ksunden commented Apr 25, 2023

@Ayush-mishra-0-0 this particular issue already has a PR associated with it (the commit above is from that PR, but it was not linked in GitHub fully, I just did that to make it more clear)

@FahadYameen
Copy link

if no one is working on it so can I start to work in this issue as my first open source contribution?

@ksunden
Copy link
Member

ksunden commented Apr 28, 2023

@FahadYameen this particular issue already has a PR associated with it, perhaps look among our other open issues.

QuLogic pushed a commit that referenced this issue May 8, 2023
@Sigma-Verma
Replace usage of WenQuanYi Zen Hei by Noto Sans CJK (#25726)
4754161 
* Update Replace usage of WenQuanYi Zen Hei by Noto Sans CJK #25724

* Update dependencies.rst

* Update whats_new_3.6.0.rst

* Update dependencies.rst

* Update fonts.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues Good first issue Open a pull request against these issues if there are no active ones! Maintenance topic: text/fonts
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging a pull request may close this issue.

Replace usage of WenQuanYi Zen Hei by Noto Sans CJK
6 participants
@tacaswell @QuLogic @anntzer @ksunden @FahadYameen @Ayush-mishra-0-0