-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[MNT]: Inconsistent API Figure.suptitle() #26691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I know it's ugly, but adding the get_{property} methods as aliases would preserve consistency. I agree w/ @jklymak that property versions like |
@jklymak proposed set-less functions That said, this would be a major API overhaul, and we'd have yet another way. While it's reasonable on its own. We should carefully decide wether we want that additional API surface, whether we want to afford this change knowing that there is more to come e.g. mpl-gui, and if we are touching on the API whether other patterns like e.g. method chaining ( |
Yeah, I should have said property-like b/c I was thinking of the pyplot pattern where the function is both the getter and setter. Which yeah, we'd want for consistency between the two APIs. |
Summary
@story645 noted in #26629 (comment)
Why is it
Figure.suptitle()
and notFigure.set_suptitle()
. Same withFigure.supxlabel()
/Figure.supylabel()
.And related: Should we do something about this?
Proposed fix
No response
The text was updated successfully, but these errors were encountered: