-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Should ContourSet.allsegs
and .allkinds
be deprecated?
#26913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
ContourSet.allsegs
and .allpaths
be deprecated?ContourSet.allsegs
and .allkinds
be deprecated?
Or maybe instead of leaving them as properties, they are rewritten as a helper |
Perhaps more general would be to have a |
That seems reasonable, if an implementation detail. The above is still a mouthful for most people. |
I'm a bit curious, though about why MOVETOs are a problem for you. After all, if you already handle allkinds, that means you already handle CLOSEPOLYs and need to differentiate between open and closed polygons, which seems already more complex than splitting at MOVETOs? |
For my application, I didn't need to know if the polygon was closed or not. I was making KML files of the contours (for using in Google Earth) and I just needed the paths. But I needed each path segment on its own so I needed lists of contiguous segments. Could I figure it out from the Path API? Probably. But it's understandably frustrating when ... or put another way; I don't think 99.9% of our users know the Path API, and I don't think they should need to learn it for this application. |
I don't feel overly strongly about this; we could just restore the old allsegs/allkinds properties (and fix them to match the old format, as you note in #26863 (comment), and mark them clearly as "exposed for practicality" so that they don't get removed in a future cleanup). |
Originally posted by @jklymak in #26863 (comment)
The text was updated successfully, but these errors were encountered: