-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[Bug]: rcParams["legend.labelcolor"] treats "none" and "None" differently #28153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would assume that users would prefer the default be black rather than transparent. Is there any reason to keep the transparent as default behavior, or can all variations of "none" be removed and replaced with "auto"? To me it makes sense to have the axis label visible by default, however, I do not know what happens if the user does not provide an axis label- would changing the default to black make axis labels required? |
I am looking at rcsetup.py, and I see xtick.labelcolor and ytick.labelcolor (I assume these are similar to axes.labelcolor) use a different function for validation code. I am going to look into changing axes.labelcolor to follow the pattern established by xtick.labelcolor and ytick.labelcolor and see if that fixes this. |
I have found something strange: matplotlib/lib/matplotlib/mpl-data/matplotlibrc Lines 359 to 381 in 80b08bd
axes.titlecolor uses auto as its default color, but axes.labelcolor uses black. Is there any reason to not use auto? |
I just noticed the title says axes.labelcolor but the body says legend.labelcolor, can you edit either the title or the body to refer to the right thing? |
Oops, fixed. |
Bug summary
The "standard" matplotlib color semantics is that the strings
"none"
and"None"
both mean fully transparent (as can be checked by mpl.colors.to_rgba); the objectNone
can sometimes be used to mark a fallback. Because the matplotlibrc format cannot distinguish betweenNone
and"None"
(due the use of unquoted strings), it normally uses "auto" or "inherit" to mark a fallback.However,
rcParams["legend.labelcolor"]
(a relatively recent introduction -- matplotlib 3.5) tries to use "None" as default, and as a result ends up having inconsistent behavior between"None"
and"none"
.Code for reproduction
Actual outcome
See above.
Expected outcome
"None" and "none" should mean the same (likely both should mean "transparent", not so much for usefulness but rather for consistency.
Additional information
I suspect trying to support the object
None
as well here basically cannot be made to work (as long as matplotlibrc uses unquoted strings); the default should switch to be "auto" (or "inherit").As a further point, the implementation of the rcParams validator
_validate_color_or_linecolor
seems wrong:Likely parentheses are missing at (1); also (2) can never hold due to the len() check.
As a side point, 3 and 4-hex color codes ("abc(d)", meaning "#abc(d)", meaning "#aabbcc(dd)") are also not supported by rcParams (this is also the case for the more general _validate_color), even though the normal color machinery does support them. At least this should be documented; I don't know if this can actually be supported without introducing an ambiguity with named colors.
Operating system
macos
Matplotlib Version
3.9.0.dev1542+geb62d6951a
Matplotlib Backend
any
Python version
3.12
Jupyter version
no
Installation
git checkout
The text was updated successfully, but these errors were encountered: