Skip to content

[MNT]: Essential build requirements not included in dev-requirements #28192

Closed
@flaviut

Description

@flaviut

Summary

Following the instructions on the dev setup page fails due to these missing dependencies:

$ python -m pip install --verbose --no-build-isolation --editable ".[dev]"
Using pip 24.0 from /home/user/dev/matplotlib/venv/lib/python3.12/site-packages/pip (python 3.12)
Obtaining file:///home/user/dev/matplotlib
  Running command Checking if build backend supports build_editable
  Checking if build backend supports build_editable ... done
...
ModuleNotFoundError: No module named 'mesonpy'

It seems like the CI tasks need to manually install them as well:

python -m pip install --upgrade meson-python numpy pybind11 setuptools-scm

and once they are manually installed locally using python -m pip install meson-python numpy pybind11 setuptools-scm, the build succeeds:

$ python -m pip install --verbose --no-build-isolation --editable ".[dev]"
...
Installing collected packages: matplotlib
  Attempting uninstall: matplotlib
    Found existing installation: matplotlib 3.8.4
    Uninstalling matplotlib-3.8.4:
      Removing file or directory /home/user/dev/matplotlib/venv/lib/python3.12/site-packages/__pycache__/pylab.cpython-312.pyc
      Removing file or directory /home/user/dev/matplotlib/venv/lib/python3.12/site-packages/matplotlib-3.8.4.dist-info/
      Removing file or directory /home/user/dev/matplotlib/venv/lib/python3.12/site-packages/matplotlib/
      Removing file or directory /home/user/dev/matplotlib/venv/lib/python3.12/site-packages/mpl_toolkits/axes_grid1/
      Removing file or directory /home/user/dev/matplotlib/venv/lib/python3.12/site-packages/mpl_toolkits/axisartist/
      Removing file or directory /home/user/dev/matplotlib/venv/lib/python3.12/site-packages/mpl_toolkits/mplot3d/
      Removing file or directory /home/user/dev/matplotlib/venv/lib/python3.12/site-packages/pylab.py
      Successfully uninstalled matplotlib-3.8.4
Successfully installed matplotlib-3.10.0.dev168+ga4243d9557

Proposed fix

Update the requirements files to include these dependencies. Update the pipelines to only use the requirements files and not manual pip calls.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions