Skip to content

[DOC]: possible typos #29313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
musvaage opened this issue Dec 14, 2024 · 8 comments · Fixed by #29346
Closed

[DOC]: possible typos #29313

musvaage opened this issue Dec 14, 2024 · 8 comments · Fixed by #29346
Milestone
v3.11.0

Comments

@musvaage
Copy link
Contributor

musvaage commented Dec 14, 2024 •
edited
Loading

Some possible additional fixes.

Homogeneous
compiled (shouldn't bother with changelog)
example
functionality
installed
logger
parameters
reset
secondary
tolerance (spelling tolerence is intentional)

$ grep -nr Homogenous matplotlib
matplotlib/galleries/users_explain/axes/constrainedlayout_guide.py:535:plt.suptitle('Homogenous nrows, ncols')
$ grep -nr compilex matplotlib
matplotlib/doc/users/prev_whats_new/changelog.rst:6117:    are Numeric typecodes and can be used with Numeric compilex extensions.
$ grep -nr exammple matplotlib
matplotlib/lib/matplotlib/sphinxext/plot_directive.py:35:        plt.title("A plotting exammple")
$ grep -nr functionaliy matplotlib
matplotlib/doc/api/next_api_changes/removals/20866-JKS.rst:5:functionaliy was already replaced by other code, and the only thing left
$ grep -nr instaled matplotlib
matplotlib/pyproject.toml:54:    # Unfortunately, we can't do a sort of minimum-if-instaled dependency, so
$ grep -nr looger matplotlib
matplotlib/doc/api/prev_api_changes/api_changes_3.1.0.rst:536:    # e.g. by configuring a root looger using ``logging.basicConfig()``,
$ grep -n parmeters matplotlib/lib/matplotlib/tests/test_colorbar.py
1211:def test_colorbar_axes_parmeters():
$ grep -nr resete matplotlib
matplotlib/lib/matplotlib/tests/test_widgets.py:1602:    # selector should be automatically resete
$ grep -nr secondart matplotlib
matplotlib/lib/matplotlib/axes/_base.py:1071:            The transform used for drawing secondart y-axis labels, which will
$ grep -nr tolerence matplotlib
matplotlib/doc/api/prev_api_changes/api_changes_3.1.0.rst:798:- The *tolerence* parameter to
$

Should the blank space be removed?

$ grep -n "pass throughs" matplotlib/lib/matplotlib/category.py
54:        # dtype = object preserves numerical pass throughs
$

I presume this is intentional.

$ grep -nr hozirontal matplotlib
matplotlib/lib/matplotlib/tests/test_text.py:412:        Text(rotation='hozirontal')
$

This seems to be bundled customised code.

$ grep -nr intialization matplotlib
matplotlib/subprojects/packagefiles/freetype-2.6.1-meson/include/freetype/config/ftoption.h.in:491:  /*   constants will be moved into a struct and additional intialization  */
$

ci/schemas/conda-environment.json

The above bundled file's typo has been fixed upstream.

microsoft/vscode-python#24574

lib/matplotlib/_color_data.py

The above file contains reproduced xkcd site content which includes typos found in the original.
@musvaage musvaage changed the title DOC: possible typos [DOC]: possible typos Dec 14, 2024
@musvaage
Copy link
Contributor Author

Sorry for not getting back to it, agree w/ @QuLogic with the caveat that you shouldn't bother w/ anything in the changelog.

@story645

Perhaps you'd adjust according to Member specifications the GNU sed lines in the following script.

Furthermore see the note above the grep output for the string hozirontal in the opening comment.

Owing to other obligations presently my preference would be a Member or other Contributor make the commit.

$ cat typos.sh
#!/bin/sh

sed -i "s/Homogenous/Homogeneous/g" matplotlib/galleries/users_explain/axes/constrainedlayout_guide.py
# sed -i "s/compilex/compiled/g" matplotlib/doc/users/prev_whats_new/changelog.rst
sed -i "s/exammple/example/g" matplotlib/lib/matplotlib/sphinxext/plot_directive.py
sed -i "s/functionaliy/functionality/g" matplotlib/doc/api/next_api_changes/removals/20866-JKS.rst
sed -i "s/instaled/installed/g" matplotlib/pyproject.toml
sed -i "s/looger/logger/g" matplotlib/doc/api/prev_api_changes/api_changes_3.1.0.rst
sed -i "s/parmeters/parameters/g" matplotlib/lib/matplotlib/tests/test_colorbar.py
# sed -i "s/pass throughs/passthroughs/g" matplotlib/lib/matplotlib/category.py
sed -i "s/resete/reset/g" matplotlib/lib/matplotlib/tests/test_widgets.py
sed -i "s/secondart/secondary/g" matplotlib/lib/matplotlib/axes/_base.py
sed -i "s/tolerence/tolerance/g" matplotlib/doc/api/prev_api_changes/api_changes_3.1.0.rst
$

@timhoffm timhoffm mentioned this issue Dec 18, 2024
Merged
@timhoffm
Copy link
Member

Thanks @musvaage!

@QuLogic QuLogic added this to the v3.11.0 milestone Dec 18, 2024
@musvaage
Copy link
Contributor Author

I had an unreliable WiFi connection so problems with cloning repos.

@timhoffm

Your commit was therefore appreciated.

this is only for my own records

the script had 2 commented out lines

additionally, these lines appear to not have been run

sed -i "s/Homogenous/Homogeneous/g" matplotlib/galleries/users_explain/axes/constrainedlayout_guide.py
sed -i "s/tolerence/tolerance/g" matplotlib/doc/api/prev_api_changes/api_changes_3.1.0.rst
```

@QuLogic
Copy link
Member

QuLogic commented Dec 19, 2024

sed -i "s/Homogenous/Homogeneous/g" matplotlib/galleries/users_explain/axes/constrainedlayout_guide.py

This is a valid spelling, apparently, though I would not use it myself.

sed -i "s/tolerence/tolerance/g" matplotlib/doc/api/prev_api_changes/api_changes_3.1.0.rst

This is intentional.

@musvaage
Copy link
Contributor Author

musvaage commented Dec 20, 2024 •
edited
Loading

my commits

for Julia's BifurcationKit were fixed spellings using for example the following

homogeneous solutions
inhomogeneous time discretisation

the antonym of homogeneous being heterogeneous

@jklymak
Copy link
Member

jklymak commented Dec 20, 2024

I certainly don't mind if someone wants to change Homogenous to Homogeneous, but the former is pretty commonly used (particularly in US English?)

@musvaage musvaage mentioned this issue Dec 21, 2024
Merged
@jklymak
Copy link
Member

jklymak commented Dec 21, 2024

the antonym of homogeneous being heterogeneous

... the antonym of homogenous being heterogenous. It's just an alternate spelling, and neither is incorrect.

@musvaage
Copy link
Contributor Author

musvaage commented Dec 21, 2024 •
edited
Loading

homogenous

reading the second edition OED

if certain circles consider that an alternate spelling it may be due to the commonality of the use of the verb homogenize

the OED entry math section's initial citation has the spelling Homogenious

that section's remaining citations use the spelling homogeneous

furthermore the spelling homogenous is used in texts on biology and surgery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging a pull request may close this issue.

DOC: fix typos timhoffm/matplotlib
4 participants
@QuLogic @jklymak @timhoffm @musvaage