Skip to content

triplot, etc examples broken by merged PR #3182 #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ianthomas23 opened this issue Jul 8, 2014 · 3 comments
Closed

triplot, etc examples broken by merged PR #3182 #3199

ianthomas23 opened this issue Jul 8, 2014 · 3 comments
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Milestone
v1.4.0

Comments

@ianthomas23
Copy link
Member

The recently merged PR #3182 removed 2 lines in each of the examples tricontour_demo.py, tripcolor_demo.py and triplot_demo.py. These lines needed to be altered, not removed. Some of the plots produced are clearly wrong, e.g.
erroneous_triplot
General rules for developers:

  1. If you change an example script, run it before and after your changes to see if the output is the same.
  2. If someone submits a PR that touches 60 files just prior to a release, either park it until after the release or be very sure it doesn't break anything.
@ianthomas23 ianthomas23 added this to the v1.4.0 milestone Jul 8, 2014
@tacaswell
Copy link
Member

I am almost inclined to revert both of those PRs.

@ianthomas23
Copy link
Member Author

@tacaswell: I agree entirely. There is the danger that other errors have been introduced, and some unnecessary formatting changes have been committed as in #3183.

@tacaswell
Copy link
Member

Reverted both #3181 and #3182.

Everyone needs to chill about the spacing around operators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v1.4.0
Development

No branches or pull requests
2 participants
@tacaswell @ianthomas23