Skip to content

Add test for cx_freeze to CI test #3391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tacaswell opened this issue Aug 21, 2014 · 12 comments · May be fixed by #18188
Closed

Add test for cx_freeze to CI test #3391

tacaswell opened this issue Aug 21, 2014 · 12 comments · May be fixed by #18188

Comments

@tacaswell
Copy link
Member

re #3385

We should add a test of cx_freeze to the travis tests.

@tacaswell tacaswell added this to the v1.5.x milestone Aug 21, 2014
@ibell
Copy link

ibell commented Mar 17, 2016

Bump. I ran into more cx-freeze issues again with 1.5.1. Every new version of MPL causes me hours of debugging to get cx-freeze working again! ARGH! In this case I had to revert to 1.3.1.

How can we get this working?

@tacaswell
Copy link
Member Author

PRs to add tests are always welcome. On the master branch we now run tests on appveyor so we will get both linux and windows coverage on the test.

I am not sure if this sort of thing fits naturally into the unit test framework, if you have a minimal script that uses cx_freeze with mpl, can you put it in the ci top level folder and run it from the travis and appveyor configs?

@ibell
Copy link

ibell commented Mar 17, 2016

I spent a few hours trying to get a simple script to package in cx_freeze
last night and ultimately gave up, finding that pyinstaller worked for my
project without any messing about.

It would still be good if we could add a test. I can put together an
example, but I have no idea how to force it to fire from the Travis or
Appveyor builds

On Thu, Mar 17, 2016 at 9:32 AM, Thomas A Caswell notifications@github.com
wrote:

PRs to add tests are always welcome. On the master branch we now run tests
on appveyor so we will get both linux and windows coverage on the test.

I am not sure if this sort of thing fits naturally into the unit test
framework, if you have a minimal script that uses cx_freeze with mpl, can
you put it in the ci top level folder and run it from the travis and
appveyor configs?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#3391 (comment)

@efiring
Copy link
Member

efiring commented Mar 18, 2016

I'm nervous about the idea of putting a test for cx_freeze in Travis. If a changeset makes the test fail, how many people are going to have the slightest idea of what to do about it--or whether it is a false alarm, given that we already have quite a bit of trouble with those?

@ibell
Copy link

ibell commented Mar 18, 2016

I certainly see your point. But it is crucial that matplotlib be able to package into an exe in some fashion or another. Ideally in both cx-freeze and PyInstaller. I frequently see problems with both packaging tools with MPL, though PyInstaller does seem the more mature option currently.

@WeatherGod
Copy link
Member

Maybe make it an "allow fail" test, like we do for the nightly python
builds?

On Fri, Mar 18, 2016 at 10:39 AM, Ian Bell notifications@github.com wrote:

I certainly see your point. But it is crucial that matplotlib be able to
package into an exe in some fashion or another. Ideally in both cx-freeze
and PyInstaller. I frequently see problems with both packaging tools with
MPL, though PyInstaller does seem the more mature option currently.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#3391 (comment)

@dopplershift
Copy link
Contributor

If we want it to stay working, it needs a test. If it breaks a bunch, we need to figure out how to make it not.

@jenshnielsen
Copy link
Member

Echoing @WeatherGod I suggest adding it to an allowed failure test in the beginning. If it works fine we can move it to a regular test.

@efiring
Copy link
Member

efiring commented Mar 18, 2016

I have no idea what requirements must be met for freezing to work. Would someone provide a link, please? And maybe an example of a change that broke freezing, and how it was fixed? If a test is added, then I suggest that this information must be added to the Developer section of the mpl docs at the same time. Or better, it could be added right away.

@tacaswell tacaswell modified the milestones: 2.1 (next point release), 2.2 (next next feature release) Oct 3, 2017
@oscargus
Copy link
Member

oscargus commented Jun 1, 2022

Is this something that is specific to travis (in that case we can close) or should it be renamed to CI (or something)?

@anntzer anntzer changed the title Add test for cx_freeze to travis test Add test for cx_freeze to CI test Feb 3, 2023
Copy link

github-actions bot commented Feb 5, 2024

This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Feb 5, 2024
@tacaswell
Copy link
Member Author

I am going to close this as won't fix.

I suspect we would merge a weekly cron job to to this test, but probably do not want to run it on every PR.

@tacaswell tacaswell closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants