Skip to content

unit tests should compare pyplot.py with output from boilerplate.py #3701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WeatherGod opened this issue Oct 22, 2014 · 10 comments · Fixed by #11204
Closed

unit tests should compare pyplot.py with output from boilerplate.py #3701

WeatherGod opened this issue Oct 22, 2014 · 10 comments · Fixed by #11204
Labels
Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues mentored: hackathon topic: testing
Milestone

Comments

@WeatherGod
Copy link
Member

I think adding a simple test that would compare the two (somehow) would be a great way to flag that a particular PR needs to have boilerplate.py executed.

@tacaswell
Copy link
Member

This is kludging a kludge. I think it should be run as part of setup.py (less good) or just gotten rid of all together (see #3587 or #2736).

@WeatherGod
Copy link
Member Author

Having it run during the setup.py! Why didn't I think of that back in v1.1?!

Oh, right... setup.py gives me migraines

Still, I see no reason why the unit test couldn't still be used to verify
that the installation was correct.

On Wed, Oct 22, 2014 at 3:50 PM, Thomas A Caswell notifications@github.com
wrote:

This is kludging a kludge. I think it should be run as part of setup.py
(less good) or just gotten rid of all together (see #3587
#3587 or #2736
#2736).


Reply to this email directly or view it on GitHub
#3701 (comment)
.

@tacaswell
Copy link
Member

@WeatherGod I have a hard time reading your level of sarcasm....

@pelson
Copy link
Member

pelson commented Oct 23, 2014

👍 - https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/tests/test_coding_standards.py is the perfect place for such a test.

I also agree with @tacaswell - it would be nice if it weren't necessary, but right now, it is...

@WeatherGod
Copy link
Member Author

@tacaswell , the sarcasm was hard to detect because there was none. I was
perfectly serious.

On Thu, Oct 23, 2014 at 4:51 AM, Phil Elson notifications@github.com
wrote:

[image: 👍] -
https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/tests/test_coding_standards.py
is the perfect place for such a test.

I also agree with @tacaswell https://github.com/tacaswell - it would be
nice if it weren't necessary, but right now, it is...


Reply to this email directly or view it on GitHub
#3701 (comment)
.

@tacaswell tacaswell modified the milestone: v1.4.x Nov 25, 2014
@tacaswell tacaswell added Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues topic: testing labels Feb 7, 2015
@tacaswell tacaswell modified the milestones: 1.5.0, v1.4.x Feb 7, 2015
@tacaswell tacaswell modified the milestones: proposed next point release, next point release Aug 9, 2015
@tacaswell
Copy link
Member

If this gets done it can go in for 1.5, but this is not a blocker

@pelson
Copy link
Member

pelson commented Aug 27, 2015

Incidentally, I did try to put it in setup.py many years ago in #928... truth is though, I'd be a bit more reluctant to do it now... we should just make use of the functionality that a non-crufty version of python brings (the original reason that pyplot wasn't just a runtime wrapper module). I know that is where you are hoping to take it currently @tacaswell, and I just wanted to say that I agree with that direction.

@QuLogic
Copy link
Member

QuLogic commented Dec 3, 2015

Is the current direction to make a runtime wrapper? Reading the previous discussions, @jkseppan had implemented something along those lines, but didn't commit it. The branch seems to have disappeared, but maybe he still has something hidden somewhere.

@mdboom
Copy link
Member

mdboom commented Dec 3, 2015

Is the current direction to make a runtime wrapper?

Yes. That's my understanding -- i.e. to not use code generation at all, though probably some dynamic creation of objects at import time (I say hand-waving away the details).

@tacaswell
Copy link
Member

Now that we have dropped 2.6 we can vendor the backport of signature (it is
currently conditionally imported from IPython) and probably do the run-time
wrapping. The major hold up on this is to not present to the users
f(*args, **kwargs) api in pyplot.

On Thu, Dec 3, 2015, 08:05 Michael Droettboom notifications@github.com
wrote:

Is the current direction to make a runtime wrapper?

Yes. That's my understanding -- i.e. to not use code generation at all,
though probably some dynamic creation of objects at import time (I say
hand-waving away the details).


Reply to this email directly or view it on GitHub
#3701 (comment)
.

@tacaswell tacaswell modified the milestones: 2.1 (next point release), 2.2 (next next feature release) Oct 3, 2017
@tacaswell tacaswell modified the milestones: needs sorting, v3.0 May 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues mentored: hackathon topic: testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants