-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
unit tests should compare pyplot.py with output from boilerplate.py #3701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Having it run during the setup.py! Why didn't I think of that back in v1.1?! Oh, right... setup.py gives me migraines Still, I see no reason why the unit test couldn't still be used to verify On Wed, Oct 22, 2014 at 3:50 PM, Thomas A Caswell notifications@github.com
|
@WeatherGod I have a hard time reading your level of sarcasm.... |
👍 - https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/tests/test_coding_standards.py is the perfect place for such a test. I also agree with @tacaswell - it would be nice if it weren't necessary, but right now, it is... |
@tacaswell , the sarcasm was hard to detect because there was none. I was On Thu, Oct 23, 2014 at 4:51 AM, Phil Elson notifications@github.com
|
If this gets done it can go in for 1.5, but this is not a blocker |
Incidentally, I did try to put it in setup.py many years ago in #928... truth is though, I'd be a bit more reluctant to do it now... we should just make use of the functionality that a non-crufty version of python brings (the original reason that pyplot wasn't just a runtime wrapper module). I know that is where you are hoping to take it currently @tacaswell, and I just wanted to say that I agree with that direction. |
Is the current direction to make a runtime wrapper? Reading the previous discussions, @jkseppan had implemented something along those lines, but didn't commit it. The branch seems to have disappeared, but maybe he still has something hidden somewhere. |
Yes. That's my understanding -- i.e. to not use code generation at all, though probably some dynamic creation of objects at import time (I say hand-waving away the details). |
Now that we have dropped 2.6 we can vendor the backport of signature (it is On Thu, Dec 3, 2015, 08:05 Michael Droettboom notifications@github.com
|
I think adding a simple test that would compare the two (somehow) would be a great way to flag that a particular PR needs to have boilerplate.py executed.
The text was updated successfully, but these errors were encountered: