Skip to content

document internal mechanics of dash scaling #7837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tacaswell opened this issue Jan 15, 2017 · 7 comments
Open

document internal mechanics of dash scaling #7837

tacaswell opened this issue Jan 15, 2017 · 7 comments
Assignees
@tacaswell
Labels
Documentation keep Items to be ignored by the “Stale” Github Action status: inactive Marked by the “Stale” Github Action
Milestone
future releases

Comments

@tacaswell
Copy link
Member

Document how the details about dashes + dash scaling + linewidth is now implemented.

There is now private 'unscaled' dash patterns (prefixed with _us in a few classes.

Also consider renaming the private variables.

Assigned to my self (as I wrote the offending code), but if someone else wants to do this I would be happy.
@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone Jan 15, 2017
@tacaswell tacaswell self-assigned this Jan 15, 2017
@tacaswell tacaswell mentioned this issue Jan 15, 2017
Merged
@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0.2 (next bug fix release) May 3, 2017
@tacaswell tacaswell modified the milestones: 2.1.1 (next bug fix release), 2.2 (next feature release) Oct 9, 2017
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Apr 5, 2023
@tacaswell
Copy link
Member Author

still needed.

@QuLogic QuLogic removed the status: inactive Marked by the “Stale” Github Action label Apr 5, 2023
@oscargus
Copy link
Member

oscargus commented Apr 5, 2023

The renaming is done as part of #23056 Maybe I can add a bit of documentation as well, now that it is a bit more unified. That should be comments in the code, right?

@github-actions GitHub Actions
Copy link

This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Apr 10, 2024
@story645
Copy link
Member

@rcomer, did this get more less covered as part of #23208 and follow ups?

@rcomer
Copy link
Member

rcomer commented Apr 10, 2024

@story645 I don’t remember documenting anything about linewidth/scaling/dash pattern as part of that work. The main documentation stumbling block was the offset parameter IIRC.

@github-actions github-actions bot removed the status: inactive Marked by the “Stale” Github Action label Apr 11, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Apr 11, 2025
@QuLogic QuLogic added the keep Items to be ignored by the “Stale” Github Action label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tacaswell tacaswell

Labels
Documentation keep Items to be ignored by the “Stale” Github Action status: inactive Marked by the “Stale” Github Action
Projects
None yet
Milestone
future releases
Development

No branches or pull requests
5 participants
@tacaswell @QuLogic @story645 @oscargus @rcomer