Skip to content

ENH: Improved color Manipulation tools #9995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jklymak opened this issue Dec 13, 2017 · 3 comments
Open

ENH: Improved color Manipulation tools #9995

jklymak opened this issue Dec 13, 2017 · 3 comments
Labels
keep Items to be ignored by the “Stale” Github Action status: inactive Marked by the “Stale” Github Action topic: color/color & colormaps
Milestone
future releases

Comments

@jklymak
Copy link
Member

jklymak commented Dec 13, 2017

Feature suggestion

In #9985 a small utility was proposed to brighten or darken a matplotlib color. The utility converted to RGB, to HLS, manipulated the L (lightness) channel, and converted back to RGB.

There was general disagreement about how exactly to do the brightening, (fractional: L*(1+frac), absolute: L + dL, or simply specifying L), the lack of a rgb_to_hls converter was lamented (to mirror the rgb_to_hsv converter, and it was suggested that a color class that simply had methods to change channels in the various color spaces would be the better approach.

Writing such a class was beyond the scope proposed in #9985, hence this issue for discussion. I'd imagine such a color class would require a MEP.
@tacaswell tacaswell added this to the v3.0 milestone Dec 13, 2017
@jklymak jklymak mentioned this issue Dec 18, 2017
Merged
@tacaswell tacaswell modified the milestones: v3.0, v3.1 Aug 11, 2018
@jklymak jklymak modified the milestones: v3.1.0, v3.2.0 Feb 27, 2019
@timhoffm timhoffm modified the milestones: v3.2.0, v3.3.0 Aug 26, 2019
@tacaswell tacaswell mentioned this issue Nov 5, 2019
Closed
6 tasks
@QuLogic QuLogic modified the milestones: v3.3.0, v3.4.0 Apr 30, 2020
@QuLogic QuLogic modified the milestones: v3.4.0, v3.5.0 Jan 27, 2021
@QuLogic QuLogic modified the milestones: v3.5.0, v3.6.0 Aug 18, 2021
@QuLogic QuLogic modified the milestones: v3.6.0, v3.7.0 Jul 8, 2022
@QuLogic QuLogic modified the milestones: v3.7.0, future releases Jan 24, 2023
@QuLogic
Copy link
Member

QuLogic commented Mar 24, 2023

As another note, the standard library contains colorsys which does contain the missing rgb_to_hls.

@github-actions GitHub Actions
Copy link

This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Jun 17, 2024
@timhoffm
Copy link
Member

Note: Seaborn has a function desaturate.
Maybe it's an option to just pull this upstream.

@timhoffm timhoffm added the keep Items to be ignored by the “Stale” Github Action label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keep Items to be ignored by the “Stale” Github Action status: inactive Marked by the “Stale” Github Action topic: color/color & colormaps
Projects
None yet
Milestone
future releases
Development

No branches or pull requests
5 participants
@tacaswell @QuLogic @jklymak @timhoffm @oscargus