TST: test mlab cohere #10019
Merged
TST: test mlab cohere #10019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
approved these changes
Dec 16, 2017
|
If you've added the test, you can do |
|
Ahhhh. I see the docs changed. They used to say |
tacaswell
added a commit
that referenced
this pull request
Dec 19, 2017
Backport PR #10019 on branch v2.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a simple test for
mlab.cohere. Would have caught #10003 (fixed by #10004). Mean to close #10012.Perfectly happy if someone else re-writes to take advantage of the parameterized framework for the rest of the spectral tests just above this test. I still grok that framework because I don't know how to run it locally as a script outside the test environment to see what is going on. For now, I think a dumb test is better than a hypothetical fancy test.
PR Checklist