Skip to content

What's new entry for color comparision method #10071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

What's new entry for color comparision method #10071

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f4c0ce6
what's new entry for color comparision method
surana-mudit Dec 21, 2017
5cddadd
what's new entry for color comparision method
surana-mudit Dec 21, 2017
8e41262
FIX: drop logic to check for repeat labels
jklymak Dec 20, 2017
8f06eac
Merge branch 'master' of https://github.com/matplotlib/matplotlib
surana-mudit Dec 31, 2017
5c9bf31
Merge branch 'master' of https://github.com/surana-mudit/matplotlib
surana-mudit Dec 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/users/next_whats_new/2017_12_17_compare_colors.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Comparision of 2 colors in Matplotlib
-------------------------------------

As Matplotlib comes with a wide variety of colors, therefore this new version allows 2 legend colors to be compared.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The sentence doesn't quite sound right - I would just remove 'therefore'
  • As @jklymak , could you reference the actual method by adding
`~matplotlib.colors.same_color`

This will show up as a link that says "same_color"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A style thing, but I somewhat favour the full names so that users can see what modules routines come from?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a good point, if you could use this instead:

`matplotlib.colors.same_color`