Skip to content

Move missing font message to debug level #10085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2018

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Dec 24, 2017

Currently building the docs (locally and on circleci) results in lots of annoying findfont messages that are like

findfont: Matching :family=STIXGeneral:style=normal:variant=normal:weight=bold:stretch=normal:size=10.0 to STIXGeneral ('/home/circleci/project/lib/matplotlib/mpl-data/fonts/ttf/STIXGeneralBol.ttf') with score of 0.000000

This PR gets rid of them by changing the log level from 'info' to 'debug'.

@tacaswell tacaswell added this to the v2.2 milestone Dec 29, 2017
@tacaswell
Copy link
Member

I am a bit concerned that this may be hiding important messages.

Could this be fixed by making sure we have the right fonts installed on circle?

@jklymak
Copy link
Member

jklymak commented Jan 2, 2018

Is the doc build run at logging.INFO? Default should be logging.WARN.

@anntzer
Copy link
Contributor

anntzer commented Jan 4, 2018

It's actually not a missing font message, just a font match (font matches are (generally) not by exact filename, but match the family entry (and other fontconfig-style entries) to the font metadata)). So unless we switch to using exact font paths, we'll always generate this message; thus I agree it should move to level INFO.
(And likewise, unless we move to using exact font paths, the notion of "right font" is a bit tricky (I didn't say "undefinable") in a fontconfig-style config.)

@anntzer anntzer merged commit 2296775 into matplotlib:master Jan 4, 2018
@dstansby dstansby deleted the font-debug branch January 4, 2018 10:20
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants