Skip to content

Logging and exception messages cleanup. #10096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 26, 2017

  • log.warning(msg % args) => log.warning(msg, *args)

  • msg = ...; raise ValueError(msg) => raise ValueError(...)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

- `log.warning(msg % args)` => `log.warning(msg, *args)`

- `msg = ...; raise ValueError(msg)` => `raise ValueError(...)`
@anntzer anntzer force-pushed the logging-exception-cleanups branch from 5301ac8 to 944a9e5 Compare December 26, 2017 09:09
@tacaswell tacaswell added this to the v2.2 milestone Dec 26, 2017
@jklymak jklymak merged commit a8ae66e into matplotlib:master Dec 26, 2017
@anntzer anntzer deleted the logging-exception-cleanups branch December 26, 2017 23:20
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants