Skip to content

Allow mplot3d rasterization; adjacent cleanups. #10158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 4, 2018

PR Summary

Redo of #10013 which has gone stale and the OP seems uninterested in learning git (and the PR needs a rebase...).

Add allow_rasterization decorators to all relevant mplot3d artists to, well, let them respect the rasterized=True option.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@PhilippVerpoort
Copy link

I haven't fully reviewed and tested all changes, but can confirm that this is an annoying bug, and that adding the @allow_rasterization keyword solved the problem for me.

See the following question and answer on Stackexchange:

https://stackoverflow.com/questions/47818231/rasterization-of-poly3dcollection-in-matplotlib

Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but would be nice to check codecov that seems to have disappeared in the last few days

@dstansby dstansby added this to the v2.2 milestone Jan 4, 2018
@anntzer anntzer force-pushed the mplot3d-rasterization branch 2 times, most recently from dc67be4 to e127653 Compare January 15, 2018 01:00
@anntzer anntzer modified the milestones: needs sorting, v3.0 Feb 17, 2018
@anntzer anntzer force-pushed the mplot3d-rasterization branch from e127653 to 83d3cf5 Compare March 26, 2018 19:21
@jklymak jklymak merged commit b1e5b9a into matplotlib:master Mar 26, 2018
@anntzer anntzer deleted the mplot3d-rasterization branch March 26, 2018 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants