Skip to content

Call kpsewhich with more arguments at one time #10238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

jkseppan
Copy link
Member

PR Summary

This is on top of #10236, but I thought it better to split it into another PR to keep the diffs smaller. This is probably best reviewed after #10236. This should improve speed for a cold cache, assuming that starting up kpsewhich is slow on your platform (which some users report in #4880).

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jkseppan
Copy link
Member Author

Rebased on top of the current version of #10236 and added some tests.

And allow batching them. This commit does not yet use the batching
but makes it possible.
- synchronous=normal (fewer disk writes, still safe in WAL mode)
- foreign key enforcement
- log sql statements at debug level
- use sqlite3.Row (enables accessing columns by name)
This should improve performance if there is a significant startup
cost to running kpsewhich, as reported by some users in matplotlib#4880.
@jkseppan jkseppan force-pushed the kpsewhich-caching-2 branch from 8caeea8 to ba47418 Compare February 18, 2018 13:02
@tacaswell tacaswell modified the milestones: v3.0, v3.1 Jul 9, 2018
@jkseppan
Copy link
Member Author

jkseppan commented Oct 6, 2018

Closing as abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants