-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
FIX: (re-allow) legend OrderedDict handles and labels... #10263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lib/matplotlib/legend.py
Outdated
else: | ||
_lab.append(label) | ||
_hand.append(handle) | ||
label, handle = _lab, _hand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plural!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh duh!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That certainly fixed it alright ;-)
9cc2506
to
3d65ca1
Compare
There seem to be a conflict, please backport manually |
FIX: (re-allow) legend OrderedDict handles and labels... Conflicts: lib/matplotlib/legend.py - conflicts on patch, kept backported version
backported to v2.1.x as c125ab4 |
PR Summary
As reported in #10262, OrderedDict input no longer works in 2.1.1. i.e.
This PR fixes that (thanks @anntzer) and adds a small test...
PR Checklist