Dvi caching #10268
Closed
Dvi caching #10268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c743a62 to
cc071ff
Compare
And allow batching them. This commit does not yet use the batching but makes it possible.
- synchronous=normal (fewer disk writes, still safe in WAL mode) - foreign key enforcement - log sql statements at debug level - use sqlite3.Row (enables accessing columns by name)
This should improve performance if there is a significant startup cost to running kpsewhich, as reported by some users in matplotlib#4880.
Expose the scale attribute, allow overriding the widths, add some convenience methods.
cc071ff to
473bec7
Compare
Along with methods to add and query the tables.
Rename the Dvi class to _DviReader and use it only for storing the files into the cache. The new Dvi class reads from the cache, after calling _DviReader to insert the file into it.
473bec7 to
2418413
Compare
6 tasks
|
Closing as abandoned. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
On top of #10236 and #10238, this adds caching of pre-parsed dvi files, removing the need to parse them again on a later date. This should improve the speed of the pdf and svg backends when
text.usetexis enabled and some of the strings have been rendered in the past, e.g. when redoing the same plot as before or changing only some of the strings.PR Checklist