Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, gtk3 widget backgrounds are not being applied (which only
matters if the figure patch is partially transparent). The lines added
by this PR are equivalent to the call to
painter.eraseRect(self.rect())
in the qt5agg backend (compare http://doc.qt.io/qt-5/qpainter.html#eraseRect
and https://developer.gnome.org/gtk3/stable/GtkStyleContext.html#gtk-render-background).
As an example, run
Without this patch, the red background is not drawn. (gtk3agg behaves in the same way after #10297 is applied).
PR Summary
PR Checklist