Skip to content

Mark the qt5 interactive test as xfail. #10315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Mark the qt5 interactive test as xfail. #10315

wants to merge 1 commit into from

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 25, 2018

PR Summary

will selfmerge if passes to unbreak the build
probably worth using strict xfail later too

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak
Copy link
Member

jklymak commented Jan 25, 2018

Can we use the old version of Qt instead of xfail?

@jklymak jklymak mentioned this pull request Jan 25, 2018
Merged
6 tasks
@anntzer
Copy link
Contributor Author

anntzer commented Jan 25, 2018

dunno if it's a qt version problem or something else, feel free to investigate and close this if your solution works.

@jklymak
Copy link
Member

jklymak commented Jan 25, 2018

Yeah it was a qt version change. 5.9 works fine.

@anntzer
Copy link
Contributor Author

anntzer commented Jan 25, 2018

closed in favor of #10316

@anntzer anntzer closed this Jan 25, 2018
@anntzer anntzer deleted the xfail-qt5 branch January 25, 2018 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @jklymak